Skip to content

notice onAuthStateChange async callback #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

notice onAuthStateChange async callback #1094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/GoTrueClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2050,6 +2050,7 @@ export default class GoTrueClient {

/**
* Receive a notification every time an auth event happens.
* A callback can be an async function and it runs synchronously during the processing of the changes causing the event. You can easily create a dead-lock by using await on a call to another method of the Supabase library.
* @param callback A callback function to be invoked when an auth event happens.
*/
onAuthStateChange(
Expand All @@ -2058,6 +2059,10 @@ export default class GoTrueClient {
data: { subscription: Subscription }
} {
const id: string = uuid()
if (callback.constructor.name === 'AsyncFunction'){
console.log("Detect onAuthStateChange async callback, do not use other Supabase functions in the callback function. If you must, dispatch the functions once the callback has finished executing. https://github.com/supabase/auth-js/issues/762")
}

const subscription: Subscription = {
id,
callback,
Expand Down
Loading