fix: avoid window.location access in SSR environments
#1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
changed the title
window.location access in SSR environments
hf
force-pushed
the
fix/ssr-initialize-crash
branch
from
467b39c to
b7b4f64
Compare
The _isValidSession method was incorrectly checking for 'expires_at' which is optional, instead of 'expires_in' which is required for valid session validation.
|
@hf It turns out that the previous fix caused a test failure because it inadvertently triggered a logic branch that wasn’t previously reachable due to I’ve identified and fixed the root cause in this commit. Could you please take another look? |
|
@hf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a Supabase client on the server side, the _initialize() method tries to access window.location.href, causing a ReferenceError and crashing the process. As a result, the method this.recoverAndRefresh responsible for restoring and refreshing the authentication state does not get called properly. other methods may recover the session later, so this doesn’t immediately break all functionality. However, this still represents an inconsistent design: recoverAndRefresh() is server-compatible, yet it's gated behind a browser-only execution path.
What is the new behavior?
This change adds a check using isBrowser() to avoid accessing window.location.href on the server side by providing empty parameters instead. This prevents the crash and allows this.recoverAndRefresh to be called correctly, enabling proper restoration and refreshing of the authentication state in server-side environments.
Additional context
Closes #1073