Support Subtract and Division of NDCube by NDData #880
+132
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtbarnes
reviewed
Sep 2, 2025
There was a problem hiding this comment.
I've tried to wrap my head around what's happening here and I don't see anything obviously problematic (though I don't know much about NDData either). My one suggestion would be adding a test that constructs an NDData from a dask array (I think this is possible??) and then apply a these operations (at least add and mul) to that object and ensure that the laziness is preserved in these new codepaths.
Cadair
reviewed
Sep 9, 2025
| @@ -1048,6 +1063,9 @@ def __radd__(self, value): | |||
| return self.__add__(value) | |||
|
|
|||
| def __sub__(self, value): | |||
| if isinstance(value, NDData): | |||
| value.data[:] = -value.data | |||
There was a problem hiding this comment.
Isn't this an in-place modification of the operand?
There was a problem hiding this comment.
with warnings.catch_warnings():
warnings.simple_filter("ignore") # This should probably be more specific to the exact warning
new_value = NDData(value, data=-value.data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.