Skip to content

Master depth calculation #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gfcapalbo
Copy link
Contributor

@gfcapalbo gfcapalbo commented Feb 6, 2024

replaces, #40 , wich was created by hussam after reverting .
PYTHON < 3.5 NOT SUPPORTED. (will exit doing nothing) subprocess.run was instroduced in that version.
tested on python 2.7 and 3.10.

If ran on 2.7, it will produce a message warning user "automatic update depth not supported for python < 3.5" and continue normal execution.

@gfcapalbo gfcapalbo force-pushed the master-depth-calculation branch from 1d3eda4 to 2b87a31 Compare February 6, 2024 11:27
@gfcapalbo gfcapalbo mentioned this pull request Feb 6, 2024
@gfcapalbo gfcapalbo force-pushed the master-depth-calculation branch from aaa697e to d31e46b Compare February 6, 2024 12:37
@gfcapalbo gfcapalbo force-pushed the master-depth-calculation branch 4 times, most recently from ff92761 to 2fc76b7 Compare February 6, 2024 13:34
@gfcapalbo
Copy link
Contributor Author

CC @thomaspaulb
@Hussam-Suleiman your message about multiple version supported should not be a problem.
this MR adds automatic depth calculations for python 3.5 and above.
for lower versions it just prints a message "no automatic depth supported".

Supporting python <3 would require a lot of coding , which i think is not warranted to support deprecated python versions.
it does not harm py 2.X projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant