Skip to content

Single wires also need to be able switch the orientation#3

Open
sundtek wants to merge 1 commit into
masterfrom
sundtek-patch-ccw-cw-single-wire-fix
Open

Single wires also need to be able switch the orientation#3
sundtek wants to merge 1 commit into
masterfrom
sundtek-patch-ccw-cw-single-wire-fix

Conversation

@sundtek
Copy link
Copy Markdown
Owner

@sundtek sundtek commented Dec 22, 2021

Single wires might also need to be able to switch the orientation, this fixes CW/CCW for the Facing operation (basically anything that would reverse wires / the cutting path)
It was assumed that this is not needed, that's why the check was there.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


Single wires might also need to be able to switch the orientation, this fixes CW/CCW for the Facing operation (basically anything that would reverse wires / the cutting path)
It was assumed that this is not needed, that's why the check was there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant