change discretize value to fix issues#1
Open
sundtek wants to merge 13 commits into
Open
Conversation
cleaned up translation method Profile translation cleanup Incorporating additional suggestions
Discretize of 0.0001 is okay for inches, but for metric <1microns would be quite small, this fixes some issues when generating paths for curves that look inward. I found following post in the forum: https://forum.freecadweb.org/viewtopic.php?f=15&t=42755 I have experienced similar issues with other curves in my object.
Depending on the input mode, either `Growth` or `Angle` is used to create a conical or flat spiral. The respective other can easily be calculated to give consistent view. This is already done for the other properties, e.g. `Height` is calculated from `Pitch` and `Turns`. With this patch, the same is done for `Angle` and `Growth`.
[PATH] Bug/translation
[PD]: Fix helix property visibility/writeability * Hide irrelevant and internal helix properties - The `HasBeenEdited` property is only used internally to check whether to fill certain other parameters with initial values. So there is no need show it in the property grid at all. - The `Outside` property is only used in the subtractive helix and thus hidden for the additive helix. * Make derived helix properties read-only Depending on the input mode, some properties are primary input, others are derived. Prior to this change, also the derived properties have been writable but their values are ignored and overwritten on the next recompute. Now, when changing the input mode, only the primary input props are writable. * Reorder some helix properties This change puts the reference axis and input mode at the top to become more prominent. Only "Base" and "Axis" are higher in the list for consistency with the other axis-based features.
all done automatically by MSVC
the internal unit is mm, only lowering the accuracy should be enough.
[PATH] change discretize value to fix issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discretize of 0.0001 is okay for inches, but for metric <1microns would be quite small, this fixes some issues when generating paths for curves that look inward.
I found following post in the forum: https://forum.freecadweb.org/viewtopic.php?f=15&t=42755
I have experienced similar issues with other curves in my object.
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!
App,Base,Guior one of theModsubfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master./bin/FreeCAD --run-test 0Fixes typo in Draft Move command textDraft: Fixed typosissue #<id>orfixes #<id>where<id>is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex:Draft: fix typos - fixes #0004805And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.