Skip to content

Conversation

absumo
Copy link
Contributor

@absumo absumo commented Sep 5, 2025

Summary by Sourcery

Update user menu route prefixes and clean up template asset inclusions

Bug Fixes:

  • Menu listener and usermenu template now use 'user_admin_overview' route instead of 'user_overview'
  • Impersonation switchback link updated to use the new route prefix

Enhancements:

  • Remove encore_entry_script_tags from user.html.twig and empty.html.twig
  • Replace error page encore stylesheet include with a static SCSS asset

Documentation:

  • Update documentation to illustrate child route activation with 'user_admin_' prefix

Was renamed in Framework-User-Implementation-Example
Js is already imported in head with assetmapper
Copy link

sourcery-ai bot commented Sep 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the user menu route to use a user_admin_ prefix across documentation and templates, removes obsolete JavaScript blocks from layout templates, and updates the error template’s CSS inclusion to a direct asset reference.

Class diagram for updated MenuListener route handling

classDiagram
    class MenuListener {
      +createMenu(factory, menu)
      -route: string (changed from 'user_overview' to 'user_admin_overview')
    }
    MenuListener --|> DefaultMenuListener
Loading

File-Level Changes

Change Details Files
Refactor user menu routing to user_admin_ prefix
  • Updated child routes example and prefix in docs
  • Changed route in example listener from user_overview to user_admin_overview
  • Adjusted impersonation exit link in usermenu template to use new route
docs/development/menu.md
templates/usermenu.html.twig
Remove obsolete JavaScript blocks
  • Deleted {% block javascripts %} and encore script tags in user.html.twig
  • Deleted {% block javascripts %} and encore script tags in empty.html.twig
templates/user.html.twig
templates/empty.html.twig
Switch error template CSS to direct asset
  • Replaced encore_entry_link_tags('error') with <link> referencing asset('styles/error.scss')
templates/base_error.html.twig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants