Skip to content

Share document modal #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Share document modal #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/frontend/apps/impress/src/components/DropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export const DropdownMenu = ({
`
}
iconName={isOpen ? 'arrow_drop_up' : 'arrow_drop_down'}
aria-hidden="true"
/>
</Box>
) : (
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/apps/impress/src/components/quick-search/QuickSearchInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const QuickSearchInput = ({
$gap={spacingsTokens['2xs']}
$padding={{ all: 'base' }}
>
{!loading && <Icon iconName="search" $variation="600" />}
{!loading && <Icon iconName="search" $variation="600" aria-hidden="true"/>}
{loading && (
<div>
<Loader size="small" />
Expand Down
2 changes: 2 additions & 0 deletions src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareMemberItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ export const DocShareMemberItem = ({ doc, access }: Props) => {
{isDesktop && doc.abilities.accesses_manage && (
<DropdownMenu options={moreActions}>
<IconOptions
aria-label={t('More actions')}
aria-hidden="true"
isHorizontal
data-testid="doc-share-member-more-actions"
$variation="600"
Expand Down
8 changes: 8 additions & 0 deletions src/frontend/apps/impress/src/i18n/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@
"Logout": "Abmelden",
"Modal confirmation to download the attachment": "Modale Bestätigung zum Herunterladen des Anhangs",
"Modal confirmation to restore the version": "Modale Bestätigung um die Version wiederherzustellen",
"More actions": "Weitere Aktionen",
"More docs": "Weitere Dokumente",
"My docs": "Meine Dokumente",
"Name": "Name",
Expand Down Expand Up @@ -324,6 +325,7 @@
"Logout": "Cerrar sesión",
"Modal confirmation to download the attachment": "Modal de confirmación para descargar el archivo adjunto",
"Modal confirmation to restore the version": "Modal de confirmación para restaurar la versión",
"More actions": "Más acciones",
"More docs": "Más documentos",
"My docs": "Mis documentos",
"Name": "Nombre",
Expand Down Expand Up @@ -512,6 +514,7 @@
"Logout": "Se déconnecter",
"Modal confirmation to download the attachment": "Modale de confirmation pour télécharger la pièce jointe",
"Modal confirmation to restore the version": "Modale de confirmation pour restaurer la version",
"More actions": "Plus d'actions",
"More docs": "Plus de documents",
"My docs": "Mes documents",
"Name": "Nom",
Expand Down Expand Up @@ -682,6 +685,7 @@
"Log in to access the document.": "Fai il login per accedere al documento.",
"Login": "Accedi",
"Logout": "Esci",
"More actions": "Altre azioni",
"More docs": "Altri documenti",
"My docs": "I miei documenti",
"Name": "Nome",
Expand Down Expand Up @@ -852,6 +856,7 @@
"Logout": "Uitloggen",
"Modal confirmation to download the attachment": "Venster bevestiging om bijlage te downloaden",
"Modal confirmation to restore the version": "Bevestiging modal om de versie te herstellen",
"More actions": "Meer acties",
"More docs": "Meer documenten",
"My docs": "Mijn documenten",
"Name": "Naam",
Expand Down Expand Up @@ -964,6 +969,7 @@
"Login": "Logga in",
"Logout": "Logga ut",
"Modal confirmation to download the attachment": "Modal bekräftelse för att ladda ner bilagan",
"More actions": "Fler åtgärder",
"No text selected": "Ingen text har valts",
"Please download it only if it comes from a trusted source.": "Vänligen ladda ner den endast om den kommer från en betrodd källa.",
"Proconnect Login": "Logga in via Proconnect",
Expand Down Expand Up @@ -1022,6 +1028,7 @@
"Load more": "Daha fazla yükle",
"Login": "Giriş yap",
"Logout": "Çıkış yap",
"More actions": "Daha fazla eylem",
"More docs": "Daha fazla belge",
"Name": "İsim",
"No active search": "Aktif arama yok",
Expand Down Expand Up @@ -1149,6 +1156,7 @@
"Logout": "退出登录",
"Modal confirmation to download the attachment": "下载附件",
"Modal confirmation to restore the version": "恢复版本的方式确认",
"More actions": "更多操作",
"More docs": "更多文档",
"My docs": "我的文档",
"Name": "名称",
Expand Down