-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3851] - Feat/Implement the mechanism to create and show the collaboration link #3966
Merged
walterbender
merged 48 commits into
sugarlabs:collaboration
from
apsinghdev:Feat/show-link
Aug 6, 2024
Merged
Changes from 47 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
72097b8
fixes #3913
walterbender 200dddb
fix:resolves grid position on hamburger opening(#3914) (#3924)
BeNikk 71fe874
Merge branch 'master' into collaboration
apsinghdev 423b467
Fix input boxes (#3927)
apsinghdev 0d082eb
bump version
walterbender eb7c23a
enhancement: scale on hover (#3926)
Anas-2357 6354fa8
calculate frequencies from ratio
walterbender 474f811
Merge branch 'master' of github.com:sugarlabs/musicblocks
walterbender ad292d9
Merge branch 'master' into collaboration
apsinghdev 5848e62
Add close button to extended-menu pie menu (fixes #3933) (#3934)
BeNikk 10ab05e
Bump braces and gulp (#3903)
dependabot[bot] 5e27904
add support for solfege accidentals in phrasemaker
walterbender 3c57c4b
Merge branch 'master' of github.com:sugarlabs/musicblocks
walterbender 530f330
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev f73597e
Merge branch 'master' into collaboration
apsinghdev 5022721
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev 55570e8
Add support for cents (#3937)
walterbender f88955e
Ratio transpose and Ratio interval (#3936)
walterbender 97e811a
fix note convert
walterbender cba02d3
remove extra comma throwing off indexing
walterbender 306888e
Merge branch 'master' into collaboration
apsinghdev 2d99514
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev 944bc2e
Hyperscore link update (#3939) (#3947)
therealharshit aaf0f6e
Update Hyperscore example link in guide.html (#3944)
GeetenParab c41d9f5
Update README.md (#3943)
akilesh1706 69f8ee8
left_and_back_images (#3950)
khadar1020 472ec5c
Updated Dockerfile (#3949)
akilesh1706 cc0b986
Merge branch 'master' into collaboration
apsinghdev 08787e1
remove yjs and socket.io dependecies
apsinghdev 8776750
Fixed #3956 Auto increasing and decreasing input block (#3957)
therealharshit 6436c2f
fixes #3941
walterbender 3b63768
Merge branch 'master' of github.com:sugarlabs/musicblocks
walterbender c415d53
fixes #3958
walterbender cc4bcef
Merge branch 'master' into collaboration
apsinghdev 3acc0b5
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev 07f9707
Fixes collapsed state of note block (#3961)
therealharshit fd39015
Merge branch 'master' into collaboration
apsinghdev de9bd23
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev 72dcdea
fixes issue with extra line number in JavaScript Editor (#3962)
haroon10725 fdbd3ff
Merge branch 'master' into collaboration
apsinghdev 8105355
Merge branch 'collaboration' of https://github.com/sugarlabs/musicblo…
apsinghdev 25a54b0
fixes sample block duplication issue (#3965)
haroon10725 5c94784
Merge branch 'master' into collaboration
apsinghdev 9e8cf6d
Show the link
apsinghdev 800686d
Create the link
apsinghdev 4932ea0
Redirect the user to the collaboration project
apsinghdev b175cc1
minor fixes
apsinghdev 0484e2b
minor fix
apsinghdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add _() so that the string is available for translation, e.g.,
this.textMsg(
_("Collaboration link: ") ${collabURL}
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@walterbender I think I have fixed it. Please have a look again.