New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palette.js: Linting and Prettify #2905

Closed

daksh4469 wants to merge 1 commit into sugarlabs:master from daksh4469:daksh4469-palette

Member

daksh4469 commented Mar 18, 2021 •

edited

Loading

Issue Reference: #2609
This patch does the following changes in js/palette.js file:

Rearranges the class declarations in the following order to prevent linting errors of the type `used before it was defined:
1. PaletteModel
2. Palette
3. Palettes
Removes unused variables: PROTOBLOCKSCALE, PALETTELEFTMARGIN, PALETTE_WIDTH_FACTOR, and NPALETTES
Adds global variables and their locations
Prettifies the code

Please review this and share your feedback @walterbender @meganindya.
Thanks.


          palette.js: Linting and Prettify

22ada04

Member

walterbender commented May 28, 2021

I think most of this was sorted out in the refactoring of activity.js

walterbender closed this

daksh4469 deleted the daksh4469-palette branch

May 29, 2021 05:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet