phrasemaker.js: Bug Fix, Linting and Prettify. #2848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js/widgets/phrasemaker.js
Outdated
Comment on lines
1430
to
1456
| if (condition === "graphicsblocks") { | ||
| if (blockLabel === "forward" || blockLabel === "back") { | ||
| for (let i = 0; i < forwardBackLabel.length; i++) { | ||
| this._pitchWheel.navItems[i].navigateFunction = __enterArgValue; | ||
| } | ||
| } else if (blockLabel === "right" || blockLabel === "left") { | ||
| for (let i = 0; i < leftRightLabel.length; i++) { | ||
| this._pitchWheel.navItems[i].navigateFunction = __enterArgValue; | ||
| } | ||
| } else if (blockLabel === "setheading") { | ||
| for (let i = 0; i < setHeadingLabel.length; i++) { | ||
| this._pitchWheel.navItems[i].navigateFunction = __enterArgValue; | ||
| } | ||
| } else if (blockLabel === "setpensize") { | ||
| for (let i = 0; i < setPenSizeLabel.length; i++) { | ||
| this._pitchWheel.navItems[i].navigateFunction = __enterArgValue; | ||
| } | ||
| } else { | ||
| for (let i = 0; i < setLabel.length; i++) { | ||
| this._pitchWheel.navItems[i].navigateFunction = __enterArgValue; | ||
| } | ||
| } | ||
| } else if (condition === "synthsblocks") { | ||
| for (let i = 0; i < valueLabel.length; i++) { | ||
| this._pitchWheel.navItems[i].navigateFunction = __enterArgValue; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please make this code dry.
Declare a variable => labelLength
put if else according to your conditions and set value of noteStored
Use for loop once.
Something like:-
let labelLength = 0;
if (condition === "graphicsblocks") {
if (blockLabel === "forward" || blockLabel === "back") {
labelLength = forwardBackLabel.length
}
} else if (blockLabel === "right" || blockLabel === "left") {
labelLength = leftRightLabel.length;
}
...
//loop just once
for (let i = 0; i < labelLength; i++) {
this._pitchWheel.navItems[i].navigateFunction = __enterArgValue;
}
}
Check this last commit. @vaibhavdaren |
daksh4469
changed the title
|
Please review this @meganindya @walterbender. |
|
I believe I should close this PR as the linting is done in #2885 by @ksraj123 and those changes have been merged and add this bug fix and some changes making the code DRY in patch #2891. Please share your feedback regarding this @walterbender @meganindya. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference: #2609
Bug:
On clicking the
dividebutton to divide a current more in half, the widget produces the messageClick on the table to add notes.every time and also re-positions the widget.screen-capture.1.mp4