Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up small_program_shapes method #2173

Closed
wants to merge 1 commit into from

Conversation

DeVikingMark
Copy link

Motivation

I was looking through the code and spotted a TODO comment in crates/core/machine/src/shape/mod.rs for cleaning up the small_program_shapes() method.

Fixes #2172

Solution

Сleaned up the method by:

  • Moving those hardcoded values to proper named constants
  • Breaking up the code into smaller, more readable chunks
  • Adding some docs to explain what the method actually does
  • Removing that old TODO

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@leruaa
Copy link
Contributor

leruaa commented Mar 26, 2025

As mentioned in the pull request template, trivial PRs are generally not accepted to not encourage PR farming.

@leruaa leruaa closed this Mar 26, 2025
@DeVikingMark
Copy link
Author

As mentioned in the pull request template, trivial PRs are generally not accepted to not encourage PR farming.

@leruaa
Salute Aurélien! I understand your policy, and I somewhat agree with it ngl, but the thing is that it's hard for me to understand what means a trivial PR, and I just want to clarify what changes you acknowledge as worth working with, with all respect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up small_program_shapes method
2 participants