feat: estimate prover gas while executing #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqn
force-pushed
the
tqn/prover-gas
branch
4 times, most recently
from
87490c9 to
53ff6a2
Compare
tqn
force-pushed
the
tqn/prover-gas
branch
2 times, most recently
from
034b99f to
d6e1719
Compare
tamirhemo
approved these changes
Mar 4, 2025
nhtyy
pushed a commit
that referenced
this pull request
Mar 6, 2025
Co-authored-by: tamirhemo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
SP1Prover::executeis called, gas is calculated, logged, and included in theExecutionReport. This behavior may be disabled by configuringSP1Context.Gas is never calculated while proving (unless an undocumented environment variable is set). This is because gas calculation requires a certain shape checking/stopping logic in the executor. The environment variable logic only exists for debugging purposes.