Garmin: Remove File Name from File Data. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the file name from the beginning of the file data buffer. This is in preparation to a move to shift the .FIT file importer to 'Import log files'. The file name in the buffer does not seem to be used for anything, and it seems to be wrong to have this added only for the parser to then have to remove this non-file-content again first thing. Fingerprinting has been confirmed as working after this change. Signed-off-by: Michael Keller <[email protected]>
mikeller
force-pushed
the
garmin_remove_filename
branch
from
6d03f62 to
f9a4d59
Compare
mikeller
added a commit
to subsurface/subsurface
that referenced
this pull request
Jan 1, 2025
Move the import of .FIT files into the 'Import log files' menu item, where most people will be looking for it. This also naturally opens a file selection dialog, which is more intuitive than having to select this in the dive computer import dialog. Also fix a bug affecting file imports if the log files contain coordinates - the dive log needs to be set in the import data structure. And refactor the file dialog file filters to make it more natural to add more entries. Requires subsurface/libdc#72 to work. Signed-off-by: Michael Keller <[email protected]>
|
Apologies @torvalds and @dirkhh for merging this before you could review it, but due to a broken git hook I accidentally pushed 5889c1a3f82d21d56cf33b62e72e73af6c5a2835 into https://github.com/subsurface/subsurface, and this needed to go in to make the .FIT log file import work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the file name from the beginning of the file data buffer. This is
in preparation to a move to shift the .FIT file importer to 'Import log
files'.
The file name in the buffer does not seem to be used for anything, and
it seems to be wrong to have this added only for the parser to then have
to remove this non-file-content again first thing.
Fingerprinting has been confirmed as working after this change.
@torvalds, @dirkhh: As the original creators of the Garmin importer, do you know if there are any hidden reasons to have the file name included in the file content buffer?
Signed-off-by: Michael Keller [email protected]