Repository navigation
Serve sets, report the uncompressed result size, version 2.17.0-rc.1 - #82
Merged
Merged
Conversation
sqd-query-engine fee829e adds sets, filters on value sets too long to send as a list. The portal now gets the result size before compression in QueryOk, which needs sqd-network main; main builds libp2p from crates.io, so the libp2p-identity patch goes away. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mo4islona
force-pushed
the
feat/sets-uncompressed-size
branch
from
October 23, 2026 19:58
1d571e9 to
e320dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
sqd-query-enginetofee829e(compare),sqd-networktof41e6b1(compare), and the worker version to2.17.0-rc.1.Upstream changes that matter here:
setsand filters refer to it by name. The worker passes the request to the engine unchanged, so it needs no code for this. The portal selects the engine per query, as before.sqd-networkmain vendors a patchedlibp2p-streaminstead of a libp2p fork, and fixes hungopen_streamcalls. Thelibp2p-identitypatch in this repo goes away with the fork.Worker changes:
QueryOkcarriesuncompressed_data_size, the result size before compression (feat(messages): add the uncompressed data size to QueryOk sqd-network#228). The field is outside the signature, so portals that predate it still verify results.DataChunk. One storage test used a chunk id with a-forksuffix, whichDataChunkrefuses; it now tells the two same-range chunks apart by hash.All tests pass locally (116). Clippy shows one warning, the same as on
master.🤖 Generated with Claude Code