[Diff] upgrade to py3.13 #4369
Draft
[Diff] upgrade to py3.13 #4369
+149
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathaxe
reviewed
Nov 1, 2025
FichteFoll
reviewed
Nov 2, 2025
FichteFoll
reviewed
Nov 3, 2025
Diff/diff.py
Outdated
Comment on lines
74
to
75
| fpath = Path(fname) | ||
| if not fname or not fpath.exists(): |
Collaborator
There was a problem hiding this comment.
Path(None) raises a TypeError and bool(Path('')) is True.
Collaborator
Author
|
I'll fix the left-overs later tonight, thanks for the feedback. |
jfcherng
reviewed
Nov 21, 2025
| def splitlines_keep_ends(text): | ||
| lines = text.split('\n') | ||
| from pathlib import Path | ||
| from typing import Iterable, Iterator |
Collaborator
There was a problem hiding this comment.
Ruff suggests this
-from typing import Iterable, Iterator
+from collections.abc import Iterable, Iterator
Collaborator
Author
There was a problem hiding this comment.
Thanks, I'll take a look later again.
FichteFoll
reviewed
Nov 21, 2025
| v: sublime.View = win.create_output_panel(name=panel_name) | ||
| if view: | ||
| v.settings().set('word_wrap', view.settings().get('word_wrap')) | ||
| v.settings().set(key="word_wrap", value=view.settings().get(key="word_wrap")) |
Collaborator
There was a problem hiding this comment.
Definitely not a fan of adding keyword argument names everywhere. What prompted you to do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.