Skip to content

Conversation

@estepnv
Copy link

@estepnv estepnv commented Jan 29, 2020

No description provided.

@suadev
Copy link
Owner

suadev commented Jan 29, 2020

@estepnv hi,

Are you sure about the syntax? It looks like ruby region is not same with csharp. Maybe you can
replace question marks below :)
...
else if (langId === "ruby") {
regionStartKey = "???";
regionEndKey = "???";
regionRegex = ???;
}

@estepnv
Copy link
Author

estepnv commented Jan 30, 2020

@suadev hey there,
yeah I'm pretty sure it's gonna work

# is a ruby single line comment keyword, the way it's described it's gonna work almost the same way it's working in IntelliJ RubyMine

@suadev
Copy link
Owner

suadev commented Jan 30, 2020

@estepnv Actually, i tried on vs code before replying you, and it did not work.

You know this is a vs code extension. Have you tried on vs code this syntax for ruby ?

@suadev
Copy link
Owner

suadev commented Jan 30, 2020

@estepnv as you can see below, not able to fold.

image

@estepnv
Copy link
Author

estepnv commented Jan 30, 2020

@suadev Sigh, I thought it’s gonna work. :(
I’m glad to contribute. Can you suggest some read so I could prepare a PR for the ruby support then?

@suadev suadev added the help wanted Extra attention is needed label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants