[WIP] jBAY and BAY vortex generator model#2273
Draft
maxi120 wants to merge 115 commits intosu2code:developfrom
Draft
[WIP] jBAY and BAY vortex generator model#2273maxi120 wants to merge 115 commits intosu2code:developfrom
maxi120 wants to merge 115 commits intosu2code:developfrom
Conversation
Added configuartion options for enabling the model, calibration constant and filename for configuring the VG geometry.
Added function to read the vg.conf file Added definition and initialization of VG object.
Implemented functions in Solver to preprocess source term and call from CDriver.
Contributor
|
Hi, Can you bring the external packages in your PR up to date? You probably missed a 'git submodule update --init' or something similar. |
Author
Thank you, should be updated now. |
d94de4e to
e242d82
Compare
e242d82 to
7edc68b
Compare
Member
|
The source term is pretty simple but the feature as a whole is very intrusive on the code, even the mesh deformation is getting involved in this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The current work implements the BAY and jBAY vortex generator source-term model using a jBAY cell selection method in the compressible and incompressible solver. The model allows to simulate triangular and rectangular vortex generators. The model is based of https://doi.org/10.4233/uuid:704d764a-6803-4cad-991f-45dc4ea38f6d.
PR Checklist
pre-commit run --allto format old commits.