Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stylelint-config-recommended-less failures due to pnpm workspace #37

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Aug 5, 2024

Which issue, if any, is this issue related to?

Closes #27

Is there anything in the PR that needs further explanation?

@romainmenke romainmenke marked this pull request as draft August 5, 2024 21:33
@romainmenke
Copy link
Member Author

🤔 One problem with pnpm is how it installs multiple versions of the same package.
I don't know pnpm well enough to know how to tune this behavior.

What we actually want is to override the installed version, not to add one more.

@Mouvedia
Copy link
Member

Mouvedia commented Aug 6, 2024

Would overrides help?

@romainmenke
Copy link
Member Author

Would overrides help?

It did!

Thank you for that suggestion @Mouvedia 🙇

@romainmenke romainmenke marked this pull request as ready for review August 19, 2024 08:46
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work! Overall LGTM, but I've left a trivial review comment.

data/ecosystem.yml Outdated Show resolved Hide resolved
@romainmenke romainmenke merged commit 3c2b864 into main Sep 8, 2024
88 of 104 checks passed
@romainmenke romainmenke deleted the stylelint-config-recommended-less--courageous-gharial-e45b809aa3 branch September 8, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix stylelint-config-recommended-less failures due to pnpm workspace
3 participants