build SDK w/ new spec #1518
Draft
build SDK w/ new spec #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
commented
May 23, 2025
xavdid-stripe
changed the title
xavdid-stripe
commented
Jun 3, 2025
| @@ -201,6 +201,7 @@ def request( | |||
| params=params, | |||
| requestor=requestor, | |||
| api_mode=api_mode, | |||
| v2_deleted_object=method == "delete" and api_mode == "V2", | |||
There was a problem hiding this comment.
this is the runtime code that ensures we turn delete responses into V2DeletedObject instead of EventDestination
We're not merging this second, but it's what we'll do when we are ready to merge.
| @@ -198,6 +198,12 @@ def get_thin_event_classes(): | |||
| return THIN_EVENT_CLASSES | |||
|
|
|||
|
|
|||
| def get_deleted_object(): | |||
There was a problem hiding this comment.
busting a circular import
| from stripe._stripe_object import StripeObject | ||
|
|
||
|
|
||
| class DeletedObject(StripeObject): |
There was a problem hiding this comment.
manually written class, references to which will get spit out by codegen
| if path == self.v1_path: | ||
| assert isinstance(resp, Customer) | ||
| else: | ||
| assert isinstance(resp, DeletedObject) |
There was a problem hiding this comment.
actual tests to ensure that delete responses work as expected. Tests are green!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE. This is just to see the output of snapshots built w/ openapi v2.
CI may fail because of changes to
DeletedObject, which is expected