Use NavigationManager in LinkActivity #10329
Open
+306
−452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| ) | ||
| } | ||
| navigationManager.tryNavigateBack() |
There was a problem hiding this comment.
goBack will go away in favor of specific screens using NavigationManager.
Comment on lines
-226
to
-225
| fun linkScreenCreated() { | ||
| viewModelScope.launch { | ||
| val currentRoute = navController?.currentBackStackEntry?.destination?.route | ||
| if (currentRoute == null || currentRoute == LinkScreen.Loading.route) { | ||
| navigateToLinkScreen() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is not needed anymore:UI does not need to signal component rendering to trigger loading. Instead, we'll wait to render the component until we have the necessary info loaded.
Comment on lines
227
to
241
| private suspend fun buildFullScreenState(): ScreenState.FullScreen { | ||
| val accountStatus = linkAccountManager.accountStatus.first() | ||
| val screen = when (accountStatus) { | ||
| AccountStatus.Verified -> { | ||
| LinkScreen.Wallet | ||
| } | ||
| AccountStatus.NeedsVerification, AccountStatus.VerificationStarted -> { | ||
| LinkScreen.Verification | ||
| } | ||
| AccountStatus.SignedOut, AccountStatus.Error -> { | ||
| LinkScreen.SignUp | ||
| return ScreenState.FullScreen( | ||
| initialDestination = when (accountStatus) { | ||
| AccountStatus.Verified -> { | ||
| LinkScreen.Wallet | ||
| } | ||
| AccountStatus.NeedsVerification, AccountStatus.VerificationStarted -> { | ||
| LinkScreen.Verification | ||
| } | ||
| AccountStatus.SignedOut, AccountStatus.Error -> { | ||
| LinkScreen.SignUp | ||
| } | ||
| } | ||
| } | ||
| navigate(screen, clearStack = true, launchSingleTop = true) | ||
| ) |
There was a problem hiding this comment.
initial step to consolidate state build logic into ScreenState.
|
Diffuse output: APK |
carlosmuvi-stripe
force-pushed
the
carlosmuvi/move-navigation-to-stripeui
branch
from
064d2dc to
1578ea5
Compare
Base automatically changed from
carlosmuvi/move-navigation-to-stripeui
to
master
March 6, 2025 20:28
carlosmuvi-stripe
force-pushed
the
carlosmuvi/use-navigation-manager
branch
from
36cda1b to
b6aaa1f
Compare
Comment on lines
-83
to
-95
| LaunchedEffect(Unit) { | ||
| onNavControllerCreated(navController) | ||
| onLinkScreenScreenCreated() | ||
| } |
There was a problem hiding this comment.
Compose does not need to signal the VM to initiate rendering anymore - instead the state has the initialDestination bundled.
Comment on lines
86
to
88
| PopUpToBehavior.Start -> popUpTo( | ||
| navHostController.graph.startDestinationId | ||
| ) { |
There was a problem hiding this comment.
Added clear stack navigation support!
toluo-stripe
previously approved these changes
Mar 10, 2025
…gation-manager # Conflicts: # paymentsheet/src/main/java/com/stripe/android/link/LinkActivityViewModel.kt # paymentsheet/src/main/java/com/stripe/android/link/ui/FullScreenContent.kt # paymentsheet/src/main/java/com/stripe/android/link/ui/LinkContent.kt
…gation-manager # Conflicts: # paymentsheet/src/main/java/com/stripe/android/link/LinkActivityViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NavigationManagerto handle navigation ((flow based navigation communication via a DI shared instance).navController<>viewModelcouplingMotivation
Testing
Screenshots
Changelog