-
Notifications
You must be signed in to change notification settings - Fork 1.4k
cert-manager support #12188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
cert-manager support #12188
Conversation
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Katherine Stanley <[email protected]>
Signed-off-by: Kate Stanley <[email protected]>
|
@ppatierno @scholzj I'm not ready to open a final PR yet, but would be interested in some initial feedback on how I'm integrating cert-manager. At the moment we have a lot of if/else checks for Strimzi managed vs cert-manager managed. I could put in further abstractions but wanted to see if 1 you thought that was needed or could be done later, and 2 if you are happy with roughly how I've laid things out before adding the abstraction code. The things I'm still working on:
|
3167e4c to
51adc9b
Compare
Signed-off-by: Kate Stanley <[email protected]>
51adc9b to
6f41bdb
Compare
Type of change
Select the type of your PR
Description
Add support for cert-manager issued certificates
Checklist
Please go through this checklist and make sure all applicable tasks have been done