-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Refactoring changes in Stride.GameStudio 2 #2970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Right forgot to test Stride.Launcher let me fix this :D |
sources/editor/Stride.GameStudio/ViewModels/DebuggingViewModel.cs
Outdated
Show resolved
Hide resolved
5f7d532 to
155969c
Compare
|
The tests should now pass 😄 |
|
Ok, I'll try to do a review very soon. Edit: likely this weekend. I couldn't find the time during the week. |
Kryptos-FR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but I'd like to point out potential conflicts with the xplat-editor branch that I would prefer to be minimized. That said, it might not be easy to adapt in this branch, so let me know. Worst case, I will manage those conflicts later when I merge master into xplat-editor.
There a few other nit picks here and there.
sources/editor/Stride.GameStudio/ViewModels/DebuggingViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made similar changes for the crash report in the xplat-editor branch. To limit future conflicts, could you reuse the same changes as much as possible?
Note in the xplat-editor branch I use Avalonia with MVVM so obviously not everything can be kept the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I converted the project from WinForms to WPF in a similar manner to your branch ,though is not identical. Perhabs I could make a PR later to your branch once my changes will merge ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have a look. Thanks, it's already of help what you did :)
sources/presentation/Stride.Core.Presentation.Wpf/XamlMarkdown.cs
Outdated
Show resolved
Hide resolved
|
I asked Claude AI to cross-check the For reference, Claude AI generated two python scripts that can be very useful to detect such issues: Claude AI analysis report (summarized)
|
Kryptos-FR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks.
PR Details
This another pack of changes around GameStudio
List of changes
fieldkeyword to shortify codeTypes of changes
Checklist