Skip to content

Conversation

@Jklawreszuk
Copy link
Collaborator

PR Details

This another pack of changes around GameStudio
List of changes

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk
Copy link
Collaborator Author

Right forgot to test Stride.Launcher let me fix this :D

@Jklawreszuk Jklawreszuk force-pushed the refactor branch 2 times, most recently from 5f7d532 to 155969c Compare November 16, 2025 18:46
@Jklawreszuk
Copy link
Collaborator Author

The tests should now pass 😄

@Kryptos-FR
Copy link
Member

Kryptos-FR commented Nov 16, 2025

Ok, I'll try to do a review very soon.

Edit: likely this weekend. I couldn't find the time during the week.

Copy link
Member

@Kryptos-FR Kryptos-FR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but I'd like to point out potential conflicts with the xplat-editor branch that I would prefer to be minimized. That said, it might not be easy to adapt in this branch, so let me know. Worst case, I will manage those conflicts later when I merge master into xplat-editor.

There a few other nit picks here and there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made similar changes for the crash report in the xplat-editor branch. To limit future conflicts, could you reuse the same changes as much as possible?

Note in the xplat-editor branch I use Avalonia with MVVM so obviously not everything can be kept the same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I converted the project from WinForms to WPF in a similar manner to your branch ,though is not identical. Perhabs I could make a PR later to your branch once my changes will merge ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a look. Thanks, it's already of help what you did :)

@Jklawreszuk Jklawreszuk changed the title Small refactoring changes in Stride.GameStudio 2 Refactoring changes in Stride.GameStudio 2 Dec 1, 2025
@Kryptos-FR
Copy link
Member

Kryptos-FR commented Dec 3, 2025

I asked Claude AI to cross-check the .pot and .po files against the code. The results are good, but we do have translations that are out of sync. It's not an issue with this PR, but we should consider taking care of it at some point (maybe for Stride 5.0 when we will have the new xplat editor).

For reference, Claude AI generated two python scripts that can be very useful to detect such issues:

Claude AI analysis report (summarized)

The PR's translation changes are technically correct:

  • ✅ All line references are accurate
  • ✅ The .pot files correctly reflect the current source code
  • ⚠️ Some .po files need updating by translators (standard maintenance)

The 3,392 inconsistencies are not errors in this PR, but rather indicate that some translation files haven't been synchronized yet with the latest source code changes.

Copy link
Member

@Kryptos-FR Kryptos-FR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants