Skip to content

suite: fix FailfastSuite failing when test.count > 1 #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

suite: fix FailfastSuite failing when test.count > 1 #1244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions suite/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,8 @@ func TestSuiteWithStats(t *testing.T) {
// It logs calls in the callOrder slice which we then use to assert the correct calls were made
type FailfastSuite struct {
Suite
callOrder []string
callOrder []string
callOrderPerRun []string
}

func (s *FailfastSuite) call(method string) {
Expand All @@ -560,11 +561,15 @@ func TestFailfastSuite(t *testing.T) {
)
assert.Equal(t, false, ok)
if failFast {
// Test A Fails and because we are running with failfast Test B never runs and we proceed straight to TearDownSuite
assert.Equal(t, "SetupSuite;SetupTest;Test A Fails;TearDownTest;TearDownSuite", strings.Join(s.callOrder, ";"))
for _, callOrder := range s.callOrderPerRun {
// Test A Fails and because we are running with failfast Test B never runs and we proceed straight to TearDownSuite
assert.Equal(t, "SetupSuite;SetupTest;Test A Fails;TearDownTest;TearDownSuite", callOrder)
}
} else {
// Test A Fails and because we are running without failfast we continue and run Test B and then proceed to TearDownSuite
assert.Equal(t, "SetupSuite;SetupTest;Test A Fails;TearDownTest;SetupTest;Test B Passes;TearDownTest;TearDownSuite", strings.Join(s.callOrder, ";"))
for _, callOrder := range s.callOrderPerRun {
// Test A Fails and because we are running without failfast we continue and run Test B and then proceed to TearDownSuite
assert.Equal(t, "SetupSuite;SetupTest;Test A Fails;TearDownTest;SetupTest;Test B Passes;TearDownTest;TearDownSuite", callOrder)
}
}
}
func TestFailfastSuiteFailFastOn(t *testing.T) {
Expand All @@ -586,6 +591,8 @@ func (s *FailfastSuite) SetupSuite() {

func (s *FailfastSuite) TearDownSuite() {
s.call("TearDownSuite")
s.callOrderPerRun = append(s.callOrderPerRun, strings.Join(s.callOrder, ";"))
s.callOrder = []string{}
}
func (s *FailfastSuite) SetupTest() {
s.call("SetupTest")
Expand Down