Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async dispose
Upgrade caused multiple errors about missing
[Symbol.asyncDispose]()
innpm run check
:Not sure how
esnext
types are used (thesdk
useses2021
intsconfig.jest.json
).Added simple implementations of
[Symbol.asyncDispose]()
toPushBuffer
andPipeLine
. That solved the issue.Bucket test
Changed
Bucket
to throwTypeError
instead of genericError
. Now functionality matches what we assert in theBucket.test.ts
.Future improvements
Add tests for the
[Symbol.asyncDispose]()
implementations (i.e. the correct cleanup actually happens)