chore(sdk) [NET-1394]: add new storage node cluster address #3020
Conversation
packages/sdk/src/Config.ts
Outdated
| export const STREAMR_STORAGE_NODE_GERMANY = '0x31546eEA76F2B2b3C5cC06B1c93601dc35c9D916' | ||
|
|
||
| export const STREAMR_STORAGE_DEFAULT = '0x9dc08ff97f5c156181ec6a0b13fc3946454e529a' |
There was a problem hiding this comment.
If we want to be very explicit, this could be named to STREAMR_STORAGE_NODE_ADDRESS and/or type this as HexString. Then it would be trivial that this is a value that can be given as an argument to addStreamToStorageNode().
There was a problem hiding this comment.
I'll add the HexString type.
About the naming, it is a bit complicated. When we refer to a storage node, we don't actually refer to a single storage node (most of the time) but a cluster of storage nodes. The correct name would therefore be something like STREAMR_STORAGE_NODE_CLUSTER_DEFAULT. However, our internal naming convention currently refers to the address as storageNodeAddress so keeping in line with that it may be wise to stick with the NODE for now. Thoughts?
There was a problem hiding this comment.
As you mentioned, end-users don't know about the clustering. In SDK's nomenclature the entity to which we add/remove streams in order to get it stored is a storage node. This is an id to such entity, and therefore we should refer it as storage node.
In practice the entity can be a single node or a cluster of nodes. As long as a real cluster (i.e more than one node) is not required, the current name is quite fine.
In summary: in my opinion we should now keep the current consistent term (STREAMR_STORAGE_NODE_ADDRESS). We can consider renaming the terminology in a follow-up PR, if needed.
There was a problem hiding this comment.
Addressed here 6a651e8
Summary
STREAMR_STORAGE_NODE_ADDRESSSTREAMR_STORAGE_NODE_GERMANYChecklist before requesting a review
TODOcomments left behind are meant to be left in.