feat: Add vars to be able to configure cloud DNS #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring Google Kubernetes Engine (GKE) Cloud DNS settings by introducing three new variables that are forwarded to the upstream GKE module.
- Added three new input variables for DNS configuration: provider, scope, and domain
- Forwarded these variables to the
gkemodule to enable Cloud DNS configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| variables.tf | Defines three new variables for cluster DNS provider, scope, and domain configuration with appropriate defaults |
| main.tf | Passes the new DNS configuration variables to the gke module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ciiiii
approved these changes
Oct 24, 2025
maxsxu
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable Cloud DNS, these variables need to be forwarded to the upstream to configure Cloud DNS
GKE setting:
