Skip to content

feat: support loki bucket for aws BYOC poolmembers #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ignacioli merged 16 commits into from
Jul 31, 2025
Merged

feat: support loki bucket for aws BYOC poolmembers #167

ignacioli merged 16 commits into from
Jul 31, 2025

Conversation

@ignacioli
Copy link

@ignacioli ignacioli commented Jul 25, 2025 •
edited
Loading

Motivation

Master Issue: https://github.com/streamnative/product-roadmap/issues/1039

BYOC AWS PoolMember bucket automation

Modifications

  1. Create s3 bucket for Loki in StreamNative's AWS account.
  2. Remove terraform life-cycle policy, which is a tech debt, and we don’t need it.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc

See readme https://github.com/streamnative/terraform-aws-cloud/blob/master/modules/dns-bucket/README.md

@ignacioli ignacioli requested a review from a team as a code owner July 25, 2025 03:43
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025

@ignacioli:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jul 25, 2025
@ignacioli ignacioli requested review from ciiiii and maxsxu July 30, 2025 15:39
ciiiii
ciiiii reviewed Jul 30, 2025
View reviewed changes
maxsxu
maxsxu reviewed Jul 31, 2025
View reviewed changes
@ignacioli ignacioli merged commit ee192f3 into master Jul 31, 2025
4 checks passed
@ignacioli ignacioli deleted the ignacio/loki-bucket branch July 31, 2025 06:59
@ignacioli ignacioli changed the title feat: support loki bucket for aws BYOC poolmebers feat(bucket): support loki bucket for aws BYOC poolmebers Jul 31, 2025
@ignacioli ignacioli removed the doc-info-missing This pr needs to mark a document option in description label Jul 31, 2025
@ignacioli ignacioli changed the title feat(bucket): support loki bucket for aws BYOC poolmebers feat: support loki bucket for aws BYOC poolmembers Jul 31, 2025
ignacioli pushed a commit that referenced this pull request Jul 31, 2025
Revert "feat: support loki bucket for aws BYOC poolmebers (#167)"
5ef6780 
This reverts commit ee192f3.
@ignacioli ignacioli mentioned this pull request Jul 31, 2025
Merged
ignacioli pushed a commit that referenced this pull request Jul 31, 2025
revert: support loki bucket for aws BYOC poolmembers (#169)
055f7f2 
Reverts #167
@ignacioli ignacioli restored the ignacio/loki-bucket branch July 31, 2025 14:21
@ignacioli ignacioli deleted the ignacio/loki-bucket branch July 31, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ciiiii ciiiii ciiiii left review comments

@maxsxu maxsxu maxsxu approved these changes

Assignees

@ignacioli ignacioli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ignacioli @maxsxu @ciiiii