perf: remove unnecessary clones from multitopic producer #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsre
force-pushed
the
massif-clone-cleanup
branch
from
43ac093 to
6ed71e8
Compare
mattsre
commented
Dec 30, 2025
| .client | ||
| .producer() | ||
| .with_topic(entry.key()) | ||
| .with_options(self.options.clone()); |
Author
There was a problem hiding this comment.
The multi-topic producer should probably share options with the inner producers to remove this clone. Would you be open to me referencing the the producer options from the multi-topic producer instead of cloning for each topic in the multi-producer? I'd need to explore how to do that without changing the single-topic producer too much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement to
send_non_blocking()on multi-topic producers to use the entry API. Removes the need to clone the topic name and get the producer after inserting it. Additional removal of an unnecessary clone on theconnect()method