Skip to content

Conversation

dselans
Copy link
Contributor

@dselans dselans commented Jun 25, 2024

  1. Remove looper to avoid races where Consume is ran in multiple goroutines. Full fix (without removing looper) would mean to create a map of loopers per Consume() but that's a decent chunk of work.
  2. Update Stop() to wait for Consume()'s to exit (using a waitgroup) + optional timeout

@dselans dselans changed the title Dselans/no looper Dselans/graceful-exit Jun 25, 2024
@dselans dselans merged commit db1dcea into main Jun 25, 2024
@dselans dselans deleted the dselans/no-looper branch June 25, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant