Dselans/handle nil acknowledger #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
^ a message could have a nil Acknowledger if rabbitmq supervisor kills a child process (due to overload, max memory usage, etc.). Since it's difficult to test this scenario - we are triggering the same reconnect logic if a `rabbit-force-reconnect` header is present as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rabbit library will now attempt to reconnect if it comes upon a
msgwith anilAcknowledgeronamqp.Delivery.I am not sure how to reproduce this as it seems to occur when RabbitMQ is under duress and RabbitMQ's supervisor kills a child that is used for the connection.
Since reproducing this test case is complicated, I added a
rabbit-force-reconnectheader check in the reconnect logic. If this header is present,rabbitlib will reconnect.Also, updated
Publish()to accept optional headers.