routing_logic and selectors refactoring
#1573
Open
+542
−747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitGab19
force-pushed
the
routing-logic-and-selectors-refactoring
branch
from
fdc78fe to
0483895
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
==========================================
+ Coverage 19.31% 19.62% +0.30%
==========================================
Files 131 132 +1
Lines 9298 9163 -135
==========================================
+ Hits 1796 1798 +2
+ Misses 7502 7365 -137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ctors dependency - Moved `selectors` and `routing_logic` modules to `mining-proxy`, isolating proxy-specific logic. - Removed `selectors` dependency from `common_properties.rs`, `handlers/mining.rs`, `routing_logic.rs`, and related modules. - Updated `IsUpstream` and `IsMiningUpstream` to remove `DownstreamSelector` and simplify their implementation. - Removed unused imports related to `selectors` and `routing_logic` across multiple modules. - Updated various `impl` blocks to match the new trait definitions without selectors. - Fixed type inconsistencies in `on_open_standard_channel_success` and `on_open_standard_channel`. - Ensured `UpstreamMiningNode` implements `HasDownstreamSelector` for proper selector access. - Fixed `DownstreamMiningNode` compatibility by enforcing `Down = DownstreamMiningNode` where needed. - Adjusted `config-examples/proxy-config-example.toml` to update upstream port. This refactor improves modularity, makes mining-proxy self-contained, and eliminates unnecessary dependencies.
GitGab19
force-pushed
the
routing-logic-and-selectors-refactoring
branch
from
0483895 to
3e62e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #1567.
It mainly removes
routing_logicandselectorsmodules fromroles-logic-sv2, given that the only real usage was done by the mining-proxy.They are now inside mining-proxy, so that we can simplify a lot both handlers, common-properties, and other roles.
Closes #1446 #1447