Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protocol deps from jd-client crate #1549

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Mar 10, 2025

blocked by #1483
partially addresses #1458

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 18.77%. Comparing base (d3b23fc) to head (1cd0a7e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
roles/pool/src/lib/error.rs 0.00% 4 Missing ⚠️
roles/jd-client/src/lib/error.rs 0.00% 3 Missing ⚠️
roles/jd-client/src/lib/downstream.rs 0.00% 2 Missing ⚠️
...d-client/src/lib/job_declarator/message_handler.rs 0.00% 2 Missing ⚠️
roles/jd-client/src/lib/upstream_sv2/upstream.rs 0.00% 1 Missing ⚠️
roles/pool/src/lib/mining_pool/mod.rs 0.00% 1 Missing ⚠️
roles/pool/src/lib/template_receiver/mod.rs 0.00% 1 Missing ⚠️
...pool/src/lib/template_receiver/setup_connection.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
- Coverage   19.07%   18.77%   -0.30%     
==========================================
  Files         134      135       +1     
  Lines        9420     9586     +166     
==========================================
+ Hits         1797     1800       +3     
- Misses       7623     7786     +163     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 8.59% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 37.68% <ø> (ø)
codec_sv2-coverage 0.03% <ø> (ø)
common_messages_sv2-coverage 0.21% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.45% <ø> (ø)
jd_client-coverage 0.44% <0.00%> (ø)
jd_server-coverage 14.76% <0.00%> (-0.04%) ⬇️
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 3.61% <ø> (ø)
mining-coverage 3.89% <ø> (+0.02%) ⬆️
mining_device-coverage 0.00% <0.00%> (ø)
mining_proxy_sv2-coverage 0.98% <0.00%> (-0.01%) ⬇️
noise_sv2-coverage 7.30% <ø> (ø)
pool_sv2-coverage 2.80% <0.00%> (-0.01%) ⬇️
protocols 27.00% <ø> (-0.13%) ⬇️
roles 6.76% <0.00%> (-0.21%) ⬇️
roles_logic_sv2-coverage 13.08% <ø> (-0.47%) ⬇️
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 10.13% <0.00%> (+0.05%) ⬆️
utils 36.39% <ø> (ø)
v1-coverage 3.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant