Fix binary sv2 proc macro #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
==========================================
+ Coverage 18.28% 18.29% +0.01%
==========================================
Files 127 127
Lines 9716 9716
==========================================
+ Hits 1777 1778 +1
+ Misses 7939 7938 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
plebhash
reviewed
Feb 24, 2025
plebhash
approved these changes
Feb 25, 2025
jbesraa
reviewed
Feb 25, 2025
Shourya742
force-pushed
the
2025-02-24-fix-binary-sv2-proc-macro
branch
2 times, most recently
from
4e409c6 to
5ff1f16
Compare
jbesraa
reviewed
Feb 25, 2025
Shourya742
force-pushed
the
2025-02-24-fix-binary-sv2-proc-macro
branch
from
5ff1f16 to
80c5b5b
Compare
pavlenex
force-pushed
the
2025-02-24-fix-binary-sv2-proc-macro
branch
from
80c5b5b to
59efad4
Compare
- Introduced a reserved set of field names (`__decodable_internal_data`, `__decodable_internal_offset`) - Added a compile-time error if a struct contains a reserved field name - Replaced all occurrences of `data` and `offset` with the reserved identifiers
pavlenex
force-pushed
the
2025-02-24-fix-binary-sv2-proc-macro
branch
from
59efad4 to
5d1160d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserve internal field names & enforce checks
__decodable_internal_data,__decodable_internal_offset)dataandoffsetwith the reserved identifierscloses: #1473