Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binary_sv2 procedural macro (in derive_codec_sv2 cannot serialize messages with fields named data) #1473

Closed
plebhash opened this issue Feb 11, 2025 · 2 comments · Fixed by #1502
Closed

binary_sv2 procedural macro (in derive_codec_sv2 cannot serialize messages with fields named data) #1473

plebhash opened this issue Feb 11, 2025 · 2 comments · Fixed by #1502
Assignees
@Shourya742
Labels
binary-sv2 bug Something isn't working
Milestone
1.3.0

Comments

@plebhash
Copy link
Collaborator

as reported on #1468 (comment)
@plebhash plebhash added this to the 1.3.0 milestone Feb 11, 2025
@plebhash plebhash added binary-sv2 bug Something isn't working labels Feb 11, 2025
@plebhash plebhash mentioned this issue Feb 18, 2025
Open
@plebhash
Copy link
Collaborator Author

@Fi3 do you have some insights here?

is this a bug or a feature?

@Fi3
Copy link
Collaborator

Fi3 commented Feb 19, 2025

is not a feature. Not sure if is worth the issue of refactoring just to allow fields named data (maybe better error would be enough) . But is definitively not a feature.

@Shourya742 Shourya742 mentioned this issue Feb 24, 2025
Merged
@plebhash plebhash moved this from Todo 📝 to In Progress 🏗️ in SV2 Roadmap 🛣️ Feb 25, 2025
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done ✅ in SV2 Roadmap 🛣️ Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shourya742 Shourya742

Labels
binary-sv2 bug Something isn't working
Projects
SV2 Roadmap 🛣️
Archived in project
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Fix binary sv2 proc macro Shourya742/stratum
3 participants
@Fi3 @Shourya742 @plebhash