Remove displayAtCheckout usage #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all usage of now deprecated displayAtCheckout and build form fields
kimcoleman
reviewed
Feb 27, 2025
| } | ||
| ?> | ||
| <div class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_form_field pmpro_form_field-required pmpro_form_field-select', 'url' ) ); ?>"> | ||
| <label for="url" class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_form_label' ) ); ?>"> |
There was a problem hiding this comment.
This should be for="testimonial_category"
|
Every field here needs an ID value = to its name value (or matching the label's "for" value. |
* FIx inconsistent CSS class usage * Addressed a11y issues with labels/ID and star selection * Fixed text domains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Resolves #24
Remove all usage of now deprecated displayAtCheckout and build form fields
How to test the changes in this Pull Request:
Other information:
Changelog entry
Testimonial submission form fields restructured to no longer use deprecated displayAtCheckout()