Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing more HTML and adding filter pmpromd_allowed_html #179

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Allowing more HTML and adding filter pmpromd_allowed_html #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,3 +590,90 @@ function pmpromd_get_display_value( $element, $pu, $displayed_levels = null ) {

return $value;
}


/**
* Function for allowed HTML tags in various templates
*
* @since TBD
* @return array $allowed_html The allowed HTML to be used for wp_kses escaping.
*/
function pmpromd_allowed_html() {
$allowed_html = wp_kses_allowed_html('post');

// Add support for iframes (YouTube, Vimeo, SoundCloud, etc.)
$allowed_html['iframe'] = [
'src' => [],
'width' => [],
'height' => [],
'frameborder' => [],
'allow' => [],
'allowfullscreen' => [],
'loading' => [],
'referrerpolicy' => [],
];

// Add support for embeds (older methods, fallback)
$allowed_html['embed'] = [
'src' => [],
'type' => [],
'width' => [],
'height' => [],
'allowfullscreen' => [],
];

// Add support for objects (legacy flash embeds, rare)
$allowed_html['object'] = [
'type' => [],
'width' => [],
'height' => [],
'data' => [],
];

// Add support for param inside object (legacy)
$allowed_html['param'] = [
'name' => [],
'value' => [],
];

// Add support for blockquotes (Twitter/X, Facebook)
$allowed_html['blockquote'] = [
'class' => [],
'cite' => [],
'lang' => [],
];

// Add support for script (for Twitter/X and other embeds that rely on JS)
$allowed_html['script'] = [
'src' => [],
'async' => [],
'defer' => [],
'type' => [],
];

// Add support for divs (for Facebook embeds)
$allowed_html['div'] = [
'class' => [],
'data-href' => [],
'data-width' => [],
'data-show-text' => [],
];

// Add support for Twitter embeds
$allowed_html['a'] = [
'href' => [],
'class' => [],
'target' => [],
'rel' => [],
'data-dnt' => [],
'data-show-count' => [],
];

/**
* Filters the allowed HTML tags for the Member Directory Add On
*
* @since TBD
* @param array $allowed_html The allowed html elements for the Member Directory escaping where wp_kses is used
*/
return apply_filters( 'pmpromd_allowed_html', $allowed_html );
}
4 changes: 2 additions & 2 deletions templates/directory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ function pmpromd_shortcode( $atts, $content=null, $code="" ) {
}
?>
<td class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_member_directory_field-' . strtok( $element[1], '|' ) ) ); ?>"<?php echo ! empty( $element[0] ) ? ' data-title="' . esc_attr( $element[0] ) . '"' : ''; ?>>
<?php echo wp_kses_post( $value ); ?>
<?php echo wp_kses( $value, pmpromd_allowed_html() ); ?>
</td>
<?php
}
Expand Down Expand Up @@ -366,7 +366,7 @@ function pmpromd_shortcode( $atts, $content=null, $code="" ) {
</div>
<?php } ?>
<div class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_member_profile_field_data' ) ); ?>">
<?php echo wp_kses_post( $value ); ?>
<?php echo wp_kses( $value, pmpromd_allowed_html() ); ?>
</div>
</div> <!-- end pmpro_member_profile_field -->
<?php
Expand Down
2 changes: 1 addition & 1 deletion templates/profile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ function pmpromd_profile_shortcode( $atts, $content=null, $code="" ) {
</div>
<?php } ?>
<div class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_member_profile_field_data' ) ); ?>">
<?php echo wp_kses_post( $value ); ?>
<?php echo wp_kses( $value, pmpromd_allowed_html() ); ?>
</div>
</div> <!-- end pmpro_member_profile_field -->
<?php
Expand Down