Skip to content

Conversation

@yakatak5
Copy link

@yakatak5 yakatak5 commented Nov 13, 2025

Description

Updating python_repl tool to check for state file directory path via environment variable: PYTHON_REPL_PERSISTENCE_DIR

As well as additional security and validation measures to ensure safe directory path referenced

Related Issues

#311

Documentation PR

Type of Change

Other (please describe): Tool Feature

Testing

Created and ran unit tests

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yakatak5 yakatak5 requested a review from a team as a code owner November 13, 2025 19:09
cagataycali
cagataycali previously approved these changes Nov 13, 2025
Copy link
Member

@awsarron awsarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yakatak5! One minor comment

@awsarron
Copy link
Member

One more thing - linter failed with:

Run hatch run test-lint
Creating environment: default
Installing project in development mode
Checking dependencies
Creating environment: hatch-static-analysis
Checking dependencies
Syncing dependencies
tests/test_python_repl.py:3:1: I001 [*] Import block is un-sorted or un-formatted
Found 1 error.
[*] 1 fixable with the `--fix` option.
Error: Process completed with exit code 1.

@yakatak5 yakatak5 requested a review from awsarron November 13, 2025 19:52
@cagataycali cagataycali enabled auto-merge (squash) November 14, 2025 14:54
cagataycali
cagataycali previously approved these changes Nov 14, 2025
Copy link
Member

@awsarron awsarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit on the README update

auto-merge was automatically disabled November 14, 2025 16:05

Head branch was pushed to by a user without write access

@yakatak5 yakatak5 requested a review from awsarron November 14, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants