-
Notifications
You must be signed in to change notification settings - Fork 210
feat: add environment variable support for python_repl directory #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Commented out the full test suite to improve commit speed.
awsarron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yakatak5! One minor comment
|
One more thing - linter failed with: |
awsarron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit on the README update
Head branch was pushed to by a user without write access
Description
Updating python_repl tool to check for state file directory path via environment variable: PYTHON_REPL_PERSISTENCE_DIR
As well as additional security and validation measures to ensure safe directory path referenced
Related Issues
#311
Documentation PR
Type of Change
Other (please describe): Tool Feature
Testing
Created and ran unit tests
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.