Fix typeScript type mismatch #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offensif
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker,
AndyBoWu and
allenchuang
as code owners
bonnie57
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Hi @offensif,
Thank you so much for your contribution and for taking the time to submit this PR! We really appreciate your effort and insights.
The txHash type looks good. Could you update this PR to address this issue across the entire repository? Additionally, it would be helpful if you could modify the PR title and description to better reflect the changes.
Thanks again for your support and for helping us improve! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix typeScript type mismatch. In other parts of the code, the transaction hash is usually represented as a Hex type, not a string.
Notes
If the type remains as string, discrepancies and potential errors will arise when handling txHash in other parts of the application that expect a Hex value.