Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in the comment for the registerGroupAndAttachLicense method #373

Closed
wants to merge 2 commits into from

Conversation

intls
Copy link

@intls intls commented Dec 29, 2024

Description

In the parameter description, request.pIds is specified, whereas in the code, the method receives and processes the array request.ipIds. This is a typo in the documentation, which can confuse developers when using the method.

Copy link
Collaborator

@bonnie57 bonnie57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @intls ,

Thank you so much for your contribution and for taking the time to submit this PR! We really appreciate your effort and insights.

It looks like the code in this PR is outdated, and we’ve already addressed the documentation errors.

For now, I’ll go ahead and close this PR, but please don’t hesitate to reach out if you have any further suggestions or questions. Your contributions are always welcome!

Thanks again for your support and for helping us improve! 🚀

@bonnie57 bonnie57 closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants