Skip to content

Conversation

@Spablob
Copy link
Collaborator

@Spablob Spablob commented May 20, 2025

Description

Adds a github action that allows proposing directly to safe multisig when merging a PR.

The steps to make it work are:

  1. Create a new PR whose titles starts with "upgrade-v" - for example "upgrade-v100.0.0". Only PRs with this title will run the GHA on merge

  2. Use the usual process to generate the the tx JSONs for "schedule", "execute" and "cancel" operations

  3. Create a PR with a specific description - can see example below and here:
    chainid: '1315' | only 1315 and 1514 are accepted - one PR will propose txs for only one chain
    operation: 'schedule' | options are 'schedule', 'cancel' and 'execute'
    previous version: '1.5.0'
    new version: '1.5.1'

  4. Reviewers confirm that the tx JSONs are correct and ready to be proposed and approve PR

  5. Merge PR - on PR merge, the txs will be proposed to Safe multisig

Spablob and others added 11 commits May 16, 2025 14:25
* gha adjustments

* gha adjustments
* add safe propose task boilerplate

* fix tx generator script

* add import the txs JSON into safePropose.ts

* JSON tx building fix
* adjust safe-propose

* adjust safe-propose
* adjust safe-propose

* adjust safe-propose

* adjust hardhat config
* adjust safe-propose

* adjust safe-propose

* adjust hardhat config

* adjust gha
* adjust safe-propose

* adjust safe-propose

* adjust hardhat config

* adjust gha

* adjust gha
@Spablob Spablob marked this pull request as ready for review May 21, 2025 00:16
Copy link

@Ramarti Ramarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix comments and LGTM

@@ -0,0 +1 @@
[{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000f97d752dd67549eef17e17cb630c96da3bbb21f80000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000f7df0dd8154a09095935725c39794150409487ca0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000c2f2f88371411801546110d8343585f2f1ccdebe0000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000ab6e87e82d885d7f7d9a6b3d1019184e670aa5c80000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a6980000000000000000000000001c8314acd72dc315e73c453c290fb83df4531d5b0000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef28600000000000000000000000045ac879dd2b1a10426e2828ddda216d1408686340000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000fa65f990980a40ee4f64ac82a96148e00ec1c5d40000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000a404b2f2b8562e82b804b042bb223548f68ba4810000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000ff5b14ffe92dfd341b3e0d5607fb9f04ddb82c020000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef28600000000000000000000000000fe25e6ba2ce73ff747f5f098e268cb2ed2cdd00000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000551eee62bbc6600c1a1d931ee382365de06b44350000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000ca077345bc611b1f1907eac8fbda4dfb25df5fc20000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a69800000000000000000000000031c1370468d47c0a86918d2b03d00773076de0a60000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000646805e71ad527965c3e8a9cc7fe5aa1e93fb65a0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a69800000000000000000000000025b11794789236fca954ebc1910d355da9636e140000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef2860000000000000000000000001f11768ed687fd8906c2168dd9e474d0c26949600000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000a77a376343a083761457654470fae8a9e30a5e5a0000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef2860000000000000000000000004595b4d7bc42adfc57b62ca3309f62a3b931390e0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a69800000000000000000000000063ca7344160ad28542590739de3f7360d70074120000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef28600000000000000000000000046cf94c58567c2be9b3b9dfe55b0b4b7dc53b7480000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000bf1f3ac9c8a88c28f21215eee0b78c8dd6c959310000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef28600000000000000000000000042d4ebd6388bc5341b0a7b46e55db852547aa0900000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000605534039930a1aefcf371795c66a5aaa534309f0000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000a9d36a826c1a1bf92b82b1ee97587c5058fcd5320000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000bd8e737e722b74bebf2f7d61011a3eb675f829340000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef28600000000000000000000000099c8d41cd6221b81eb15b8becff01927011ebd030000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a69800000000000000000000000056e805a31c00e6e829e3a842f8ea205a52cfeb990000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef2860000000000000000000000002ea7d910cb4cedf82e542d51e4162f7d5f76293e0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000551eee62bbc6600c1a1d931ee382365de06b4435000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024fc761919000000000000000000000000c7d70c22d40c1804ce60ecd947040c11e6523d7300000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000e81d51d8a9758d84ffd0577e5e98f73bf73c69e10000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000dd78eb2a50d8ed9386fd6f7e3b3afdca1704236f0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000dc0efc100d90b3bd96197f294f502f86baba02020000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000d5a8856adb5d8765090d27e8f4f73d495334488a0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000d62f6d849f0c61e2527f5052009fd475a688daec0000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000644f1ef286000000000000000000000000afbc826b61ed009c25b174e141f7f251106dfc550000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","operation":0},{"to":"0xCF674Bbbe0b5cAda4B9b320F823c34E8b2A44de9","value":0,"data":"0xf801a698000000000000000000000000c2f2f88371411801546110d8343585f2f1ccdebe000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024b5b49670000000000000000000000000f0f8a8ab9ee5717eb901a41f47b1f8ab693d885a00000000000000000000000000000000000000000000000000000000","operation":0}] No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do we need to check-in the output file?
  • What's the version v1.5.0 and v1.5.1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we don't need this file anymore. It was only needed during testing. Removed in 2d38cbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants