Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(classNames): 🔍 ensure application to the right element #55

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mitchelvanbever
Copy link
Member

We probably want to check all the components to ensure the className that is being passed from the styled function is applied to the right element. For the toggle this gave some headaches because of the nested structure of the css rules.

Fixed toggle but feel free to check/fix other components

@vercel
Copy link

vercel bot commented Oct 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/storyofams/react-ui/DVpH6xvaF7X6UrB2SWM36hmzX9Ak
✅ Preview: https://react-ui-git-chore-extend-classname-location-storyofams.vercel.app

@mitchelvanbever mitchelvanbever changed the title Draft: refactor(classNames): 🔍 ensure application to the right element refactor(classNames): 🔍 ensure application to the right element Oct 22, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #55 (ecec737) into master (5d835cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          29       29           
  Lines         343      343           
  Branches       80       80           
=======================================
  Hits          342      342           
  Misses          1        1           
Flag Coverage Δ
typescript ?
unittest 99.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/common/Toggle/index.tsx 93.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d835cc...ecec737. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant