Skip to content

Commit

Permalink
fix(monorepo): Resolved issue with invalid prettier config used in …
Browse files Browse the repository at this point in the history
…hooks
  • Loading branch information
sullivanpj committed Feb 3, 2025
1 parent f67dbe9 commit 3497491
Show file tree
Hide file tree
Showing 403 changed files with 26,702 additions and 18,356 deletions.
68 changes: 34 additions & 34 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
@@ -1,36 +1,36 @@
{
"projectName": "storm-ops",
"projectOwner": "storm-software",
"repoType": "github",
"repoHost": "https://github.com",
"files": ["README.md"],
"imageSize": 100,
"commit": true,
"commitConvention": "angular",
"contributors": [
{
"login": "sullivanpj",
"name": "Patrick Sullivan",
"avatar_url": "https://avatars.githubusercontent.com/u/99053093?v=4",
"profile": "http://www.sullypat.com/",
"contributions": ["design", "code", "tool", "doc", "test"]
},
{
"login": "tbenning",
"name": "Tyler Benning",
"avatar_url": "https://avatars.githubusercontent.com/u/7265547?v=4",
"profile": "https://tylerbenning.com/",
"contributions": ["design"]
},
{
"login": "stormie-bot",
"name": "Stormie",
"avatar_url": "https://avatars.githubusercontent.com/u/149802440?v=4",
"profile": "http://stormsoftware.com",
"contributions": ["maintenance"]
}
],
"contributorsPerLine": 7,
"linkToUsage": true,
"commitType": "docs"
"projectName": "storm-ops",
"projectOwner": "storm-software",
"repoType": "github",
"repoHost": "https://github.com",
"files": ["README.md"],
"imageSize": 100,
"commit": true,
"commitConvention": "angular",
"contributors": [
{
"login": "sullivanpj",
"name": "Patrick Sullivan",
"avatar_url": "https://avatars.githubusercontent.com/u/99053093?v=4",
"profile": "http://www.sullypat.com/",
"contributions": ["design", "code", "tool", "doc", "test"]
},
{
"login": "tbenning",
"name": "Tyler Benning",
"avatar_url": "https://avatars.githubusercontent.com/u/7265547?v=4",
"profile": "https://tylerbenning.com/",
"contributions": ["design"]
},
{
"login": "stormie-bot",
"name": "Stormie",
"avatar_url": "https://avatars.githubusercontent.com/u/149802440?v=4",
"profile": "http://stormsoftware.com",
"contributions": ["maintenance"]
}
],
"contributorsPerLine": 7,
"linkToUsage": true,
"commitType": "docs"
}
9 changes: 3 additions & 6 deletions .github/labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@
description: "Issue is currently being resolved by a developer."
- name: "stale"
color: fef2c0
description:
"There has not been activity on this issue or PR for quite some time."
description: "There has not been activity on this issue or PR for quite some time."
- name: "no-stale"
color: fef2c0
description: "This issue or PR is exempted from the stable bot."
Expand All @@ -61,12 +60,10 @@

- name: "beginner-friendly"
color: 0e8a16
description:
"Good first issue for people wanting to contribute to the project."
description: "Good first issue for people wanting to contribute to the project."
- name: "help-wanted"
color: 0e8a16
description:
"We need some extra helping hands or expertise in order to resolve this."
description: "We need some extra helping hands or expertise in order to resolve this."

- name: "priority-critical"
color: ee0701
Expand Down
2 changes: 1 addition & 1 deletion .vscode/tasks.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"version": "2.0.0",
"tasks": []
}
}
25 changes: 13 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,25 +46,26 @@ keeping the codebase maintainable.

<!-- START doctoc -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

## Table of Contents

- [Quick Features](#quick-features)
- [Included Packages](#included-packages)
- [Tech Stack](#tech-stack)
- [Included Packages](#included-packages)
- [Tech Stack](#tech-stack)
- [Getting Started](#getting-started)
- [Build](#build)
- [Development Server](#development-server)
- [Build](#build)
- [Development Server](#development-server)
- [Environment Configuration Help](#environment-configuration-help)
- [Plug-Ins](#plug-ins)
- [Generate an Application](#generate-an-application)
- [Generate a Library](#generate-a-library)
- [Code Scaffolding](#code-scaffolding)
- [Plug-Ins](#plug-ins)
- [Generate an Application](#generate-an-application)
- [Generate a Library](#generate-a-library)
- [Code Scaffolding](#code-scaffolding)
- [Testing](#testing)
- [Running Unit Tests](#running-unit-tests)
- [Running End-to-End Tests](#running-end-to-end-tests)
- [Understand your workspace](#understand-your-workspace)
- [Running Unit Tests](#running-unit-tests)
- [Running End-to-End Tests](#running-end-to-end-tests)
- [Understand your workspace](#understand-your-workspace)
- [☁ Nx Cloud](#-nx-cloud)
- [Distributed Computation Caching & Distributed Task Execution](#distributed-computation-caching--distributed-task-execution)
- [Distributed Computation Caching & Distributed Task Execution](#distributed-computation-caching--distributed-task-execution)
- [Roadmap](#roadmap)
- [Contributing](#contributing)
- [Support](#support)
Expand Down
21 changes: 11 additions & 10 deletions crates/storm-config/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,20 @@ This package is part of the <b>⚡Storm-Ops</b> monorepo. The Storm-Ops packages

<!-- START doctoc -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

## Table of Contents

- [Storm Configuration Crate](#storm-configuration-crate)
- [Installing](#installing)
- [Building](#building)
- [Running unit tests](#running-unit-tests)
- [Storm Workspaces](#storm-workspaces)
- [Roadmap](#roadmap)
- [Support](#support)
- [License](#license)
- [Changelog](#changelog)
- [Contributing](#contributing)
- [Contributors](#contributors)
- [Installing](#installing)
- [Building](#building)
- [Running unit tests](#running-unit-tests)
- [Storm Workspaces](#storm-workspaces)
- [Roadmap](#roadmap)
- [Support](#support)
- [License](#license)
- [Changelog](#changelog)
- [Contributing](#contributing)
- [Contributors](#contributors)

<!-- END doctoc -->

Expand Down
21 changes: 11 additions & 10 deletions crates/storm-workspace/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,20 @@ This package is part of the <b>⚡Storm-Ops</b> monorepo. The Storm-Ops packages

<!-- START doctoc -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

## Table of Contents

- [Storm Workspace Management Crate](#storm-workspace-management-crate)
- [Installing](#installing)
- [Building](#building)
- [Running unit tests](#running-unit-tests)
- [Storm Workspaces](#storm-workspaces)
- [Roadmap](#roadmap)
- [Support](#support)
- [License](#license)
- [Changelog](#changelog)
- [Contributing](#contributing)
- [Contributors](#contributors)
- [Installing](#installing)
- [Building](#building)
- [Running unit tests](#running-unit-tests)
- [Storm Workspaces](#storm-workspaces)
- [Roadmap](#roadmap)
- [Support](#support)
- [License](#license)
- [Changelog](#changelog)
- [Contributing](#contributing)
- [Contributors](#contributors)

<!-- END doctoc -->

Expand Down
2 changes: 1 addition & 1 deletion jest.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { getJestProjects } from "@nx/jest";

export default {
projects: getJestProjects()
projects: getJestProjects(),
};
6 changes: 3 additions & 3 deletions lefthook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ pre-push:
prettier:
files: "git diff --name-only HEAD @{push}"
glob: "!**/generators/*/files/**/*"
run: "pnpm exec prettier {files} --write --ignore-unknown
--no-error-on-unmatched-pattern --cache && git update-index"
run: 'pnpm exec prettier {files} --write --ignore-unknown
--no-error-on-unmatched-pattern --cache --config="./packages/prettier/src/config.json" && git update-index'
stage_fixed: true
sherif:
files: "git diff --name-only HEAD @{push}"
Expand All @@ -113,7 +113,7 @@ pre-push:
stage_fixed: true
format:
files: "git diff --name-only HEAD @{push}"
glob: "**/*"
glob: "!**/generators/*/files/**/*"
run: "pnpm nx format:write --files {files} --sort-root-tsconfig-paths
--all && git update-index"
stage_fixed: true
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -177,5 +177,6 @@
"tough-cookie": "4.1.4"
}
},
"prettier": "./packages/prettier/src/config.json",
"triggerEmptyDevReleaseByIncrementingThisNumber": 0
}
21 changes: 11 additions & 10 deletions packages/build-tools/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,20 @@ This package is part of the <b>⚡Storm-Ops</b> monorepo. The Storm-Ops packages

<!-- START doctoc -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

## Table of Contents

- [Storm Build Tools](#storm-build-tools)
- [Installing](#installing)
- [Building](#building)
- [Running unit tests](#running-unit-tests)
- [Storm Workspaces](#storm-workspaces)
- [Roadmap](#roadmap)
- [Support](#support)
- [License](#license)
- [Changelog](#changelog)
- [Contributing](#contributing)
- [Contributors](#contributors)
- [Installing](#installing)
- [Building](#building)
- [Running unit tests](#running-unit-tests)
- [Storm Workspaces](#storm-workspaces)
- [Roadmap](#roadmap)
- [Support](#support)
- [License](#license)
- [Changelog](#changelog)
- [Contributing](#contributing)
- [Contributors](#contributors)

<!-- END doctoc -->

Expand Down
4 changes: 2 additions & 2 deletions packages/build-tools/jest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ export default {
preset: "../../jest.preset.js",
testEnvironment: "node",
transform: {
"^.+\\.[tj]s$": ["ts-jest", { tsconfig: "<rootDir>/tsconfig.spec.json" }]
"^.+\\.[tj]s$": ["ts-jest", { tsconfig: "<rootDir>/tsconfig.spec.json" }],
},
moduleFileExtensions: ["ts", "js", "html"],
coverageDirectory: "../../coverage/packages/build-tools"
coverageDirectory: "../../coverage/packages/build-tools",
};
4 changes: 2 additions & 2 deletions packages/build-tools/src/plugins/analyze.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { writeInfo } from "@storm-software/config-tools/logger/console";

const formatBytes = bytes => {
const formatBytes = (bytes) => {
if (bytes === 0) {
return "0 Bytes";
}
Expand All @@ -22,6 +22,6 @@ export function analyze() {
const sourceBytes = formatBytes(source.length);
const fileName = chunk.fileName;
writeInfo(` - ${fileName} ${sourceBytes}`);
}
},
};
}
8 changes: 4 additions & 4 deletions packages/build-tools/src/plugins/swc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ export function swc(): Plugin {
filename,
jsc: {
transform: {
react: { runtime: "automatic" }
}
}
react: { runtime: "automatic" },
},
},
});
}
},
};
}
14 changes: 7 additions & 7 deletions packages/build-tools/src/plugins/ts-resolve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type { PluginImpl } from "rollup";

const resolveModule = (
id: string,
opts: _resolve.AsyncOpts
opts: _resolve.AsyncOpts,
): Promise<string | null> =>
new Promise((resolve, reject) => {
_resolve(id, opts, (err, res) => {
Expand All @@ -24,7 +24,7 @@ export type TsResolveOptions = {

export const tsResolvePlugin: PluginImpl<TsResolveOptions> = ({
resolveOnly,
ignore
ignore,
} = {}) => {
const resolveExtensions = [".d.ts", ".ts"];

Expand Down Expand Up @@ -54,7 +54,7 @@ export const tsResolvePlugin: PluginImpl<TsResolveOptions> = ({
}

if (resolveOnly) {
const shouldResolve = resolveOnly.some(v => {
const shouldResolve = resolveOnly.some((v) => {
if (typeof v === "string") return v === source;
return v.test(source);
});
Expand All @@ -78,7 +78,7 @@ export const tsResolvePlugin: PluginImpl<TsResolveOptions> = ({
if (source[0] === ".") {
return resolveModule(source, {
basedir,
extensions: resolveExtensions
extensions: resolveExtensions,
});
}

Expand All @@ -88,7 +88,7 @@ export const tsResolvePlugin: PluginImpl<TsResolveOptions> = ({
if (!importer) {
id = await resolveModule(`./${source}`, {
basedir,
extensions: resolveExtensions
extensions: resolveExtensions,
});
}

Expand All @@ -101,7 +101,7 @@ export const tsResolvePlugin: PluginImpl<TsResolveOptions> = ({
pkg.main = pkg.types || pkg.typings;
return pkg;
},
paths: ["node_modules", "node_modules/@types"]
paths: ["node_modules", "node_modules/@types"],
});
}

Expand All @@ -113,6 +113,6 @@ export const tsResolvePlugin: PluginImpl<TsResolveOptions> = ({
// Just make it external if can't be resolved, i.e. tsconfig path alias
writeDebug(`ts-resolve - mark ${source} as external`);
return false;
}
},
};
};
8 changes: 4 additions & 4 deletions packages/build-tools/src/plugins/type-definitions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ export function typeDefinitions(options: { projectRoot: string }): Plugin {
const hasDefaultExport = file.exports.includes("default");
const entrySourceFileName = relative(
options.projectRoot,
file.facadeModuleId
file.facadeModuleId,
);
const entrySourceDtsName = entrySourceFileName.replace(
/\.[cm]?[jt]sx?$/,
""
"",
);
const dtsFileName = file.fileName.replace(/\.[cm]?js$/, ".d.ts");
const relativeSourceDtsName = JSON.stringify("./" + entrySourceDtsName);
Expand All @@ -47,9 +47,9 @@ export function typeDefinitions(options: { projectRoot: string }): Plugin {
this.emitFile({
type: "asset",
fileName: dtsFileName,
source: dtsFileSource
source: dtsFileSource,
});
}
}
},
};
}
Loading

0 comments on commit 3497491

Please sign in to comment.