Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: a few improvements to the dry-run, allocations and snapshot update scripts #457

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: a few improvements to the dry-run, allocations and snapshot update scripts #457

wants to merge 5 commits into from

Conversation

travis
Copy link
Member

@travis travis commented Jan 23, 2025

  • simplify configuration by hard coding table names - I thought about trying to extract this to a constant but decided it's at least a separate project if it's worth doing at all - happy to jump into that in a quick followup if anyone strongly prefers it
  • fix upsert snapshot script to work for more than 100 snapshots

travis added 4 commits January 13, 2025 16:56
@travis
fix: add a bit more logging to help track down usage billing bugs
d06a342 
For some reason some space snapshots have been missed in the past, despite seemingly being in the DB and showing up in dry run.
@travis
fix: a few more tweaks
00a1bd3 
remove one log line since it's already covered by a different line, and improve that line

throw an error rather than just returning silently if we receive an insert event with no records - I think this is an error, since I'm not sure when it could happen
@travis
fix: one more log line
398edcb
@travis
feat: a few improvements to the dry-run, allocations and snapshot upd…
97e7bd1 
…ate scripts

* simplify configuration by hard coding table names - I thought about trying to extract this to a constant but decided it's at least a separate project if it's worth doing at all - happy to jump into that in a quick followup if anyone strongly prefers it
* fix upsert snapshot script to work for more than 100 snapshots
@travis travis requested a review from BravoNatalie January 23, 2025 20:20
@seed-deploy Seed Deploy
Copy link

seed-deploy bot commented Jan 23, 2025

View stack outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BravoNatalie BravoNatalie Awaiting requested review from BravoNatalie

@alanshaw alanshaw Awaiting requested review from alanshaw

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@travis