Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to json-schema-ref-parser #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Apr 26, 2020

This is a breaking change.

My apologies regarding
"@apidevtools/json-schema-ref-parser": "https://github.com/stoplightio/json-schema-ref-parser#03462047af4e62e889038f5e4ce53c552fbefaee",
but we've got 3 changes that are not merged yet, but are fairly important from our perspective.

@P0lip P0lip added the enhancement New feature or request label Apr 26, 2020
@P0lip P0lip self-assigned this Apr 26, 2020
@marbemac
Copy link

Should we just update to use @stoplight/json-schema-ref-parser rather than do the github URL thing? We're being good about opening PRs to original lib, but generally we'll want the updates in our ecosystem faster than PRs can get through on the main lib.

@marbemac
Copy link

This is a breaking change.

Can you elaborate? What's affected, what needs to be updated, how risky, etc?

@lottamus lottamus removed their request for review July 15, 2020 15:01
@marbemac marbemac removed request for marbemac and XVincentX July 8, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants