force delete crd work after deleting condition is true #753
Conversation
zhiweiyin318
force-pushed
the
delete-crd-work
branch
3 times, most recently
from
68abd4c to
fdcb544
Compare
|
/assign @qiujian16 |
zhiweiyin318
force-pushed
the
delete-crd-work
branch
2 times, most recently
from
5a39e2c to
cc838df
Compare
| if works.Items[0].DeletionTimestamp.IsZero() { | ||
| crdWork := works.Items[0] | ||
| if crdWork.DeletionTimestamp.IsZero() { | ||
| return r.clientHolder.WorkClient.WorkV1().ManifestWorks(cluster.Name). |
There was a problem hiding this comment.
I recall that the registration controller is responsible for deleting this ManifestWork. Why is the import-controller also deleting it?
There was a problem hiding this comment.
you are right. do not need delete again here.
fixed.
zhiweiyin318
force-pushed
the
delete-crd-work
branch
from
cc838df to
082cdeb
Compare
| if crdWork.DeletionTimestamp.IsZero() || | ||
| !meta.IsStatusConditionTrue(crdWork.Status.Conditions, workv1.WorkDeleting) { |
There was a problem hiding this comment.
I believe !meta.IsStatusConditionTrue(crdWork.Status.Conditions, workv1.WorkDeleting is sufficient. What do you think?
Signed-off-by: Zhiwei Yin <[email protected]>
zhiweiyin318
force-pushed
the
delete-crd-work
branch
from
082cdeb to
77a269c
Compare
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
openshift-merge-bot
bot
merged commit d192672
into
stolostron:main
|
/cherry-pick backplane-2.9 |
|
@elgnay: new pull request created: #801 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
No description provided.