Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of driver enable. #106

Closed
wants to merge 2 commits into from
Closed

Initial implementation of driver enable. #106

wants to merge 2 commits into from

Conversation

justinlatimer
Copy link
Contributor

I've implemented Driver Enable pins for the USART abstraction. Tested with RS485 hardware on an STM32G030. Happy for feedback. Thanks!

@andresv
Copy link
Member

andresv commented Jun 24, 2022 •
edited
Loading

Thanks for the PR.
CI fails at the moment, could you run cargo fmt.

@justinlatimer
Copy link
Contributor Author

Formatting updated!

@andresv
Copy link
Member

andresv commented Jun 27, 2022

Could you also add rs485 example.

@justinlatimer
Copy link
Contributor Author

I've added an example of using the usart_with_driver_enable() function.

@andresv andresv requested a review from dotcypress July 5, 2022 07:01
@andresv
Copy link
Member

andresv commented Jul 5, 2022

@dotcypress do you have any objections?

@dotcypress
Copy link
Member

@justinlatimer thank you for your help!

I'm not happy with paste! macro. Maybe we can implement this feature without macro hell.
I will take a deep look into it a bit later this week.

@dotcypress dotcypress mentioned this pull request Jul 8, 2022
Merged
@justinlatimer
Copy link
Contributor Author

Superseded by #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresv andresv andresv approved these changes

@dotcypress dotcypress Awaiting requested review from dotcypress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinlatimer @andresv @dotcypress