Skip to content

Add initial STM32F070 support #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 20, 2018
Merged

Add initial STM32F070 support #9

merged 8 commits into from
Dec 20, 2018

Conversation

jessebraham
Copy link
Contributor

Alright, so I did my best to just duplicate #3 as much as possible with this.

Basically just adds the minimal required support for the STM32F070X6 and STM32F070XB devices. There are in fact hardware differences between the two families (which is why they are represented as separate features), they just have not been reflected in code yet.

If there are any changes to be made please just let me know and I'll be glad to do so 😄

Copy link
Member

@david-sawatzke david-sawatzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me otherwise

@david-sawatzke
Copy link
Member

david-sawatzke commented Dec 19, 2018

You'll likely want to wait until #6 is merged for the serial ports.
(Probably for i2c and spi as wel)

@jessebraham
Copy link
Contributor Author

jessebraham commented Dec 19, 2018

Awesome, thanks for taking the time to look it over. I can get the timer issue resolved later today, and I'll take a look at #6 and attempt make the appropriate changes to Serial and take a swing at I2C/SPI as well.

@jessebraham
Copy link
Contributor Author

jessebraham commented Dec 20, 2018

Okay, first off I merged in #6 from master just to get my branch current. I then made the modifications to the 3 Timers @david-sawatzke pointed out, removing support for the STM32F070X6 devices. I then re-implemented Serial using the new methods merged in from master.

Please let me know if anybody spots any discrepancies. Once the above has been approved I intend to implement I2C and SPI as well; should those be in the same pull request or should we merge this first and create a separate pull request?

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@therealprof therealprof merged commit 5af487e into stm32-rs:master Dec 20, 2018
@jessebraham jessebraham deleted the stm32f070-support branch January 11, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants