-
Notifications
You must be signed in to change notification settings - Fork 60
Add initial STM32F070 support #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me otherwise
You'll likely want to wait until #6 is merged for the serial ports. |
Awesome, thanks for taking the time to look it over. I can get the timer issue resolved later today, and I'll take a look at #6 and attempt make the appropriate changes to Serial and take a swing at I2C/SPI as well. |
Okay, first off I merged in #6 from Please let me know if anybody spots any discrepancies. Once the above has been approved I intend to implement I2C and SPI as well; should those be in the same pull request or should we merge this first and create a separate pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Alright, so I did my best to just duplicate #3 as much as possible with this.
Basically just adds the minimal required support for the
STM32F070X6
andSTM32F070XB
devices. There are in fact hardware differences between the two families (which is why they are represented as separate features), they just have not been reflected in code yet.If there are any changes to be made please just let me know and I'll be glad to do so 😄