-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker images to reduce security vulnerabilities #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snyk Container found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Tagging @mcrusch and @claymcleod so they're aware. Specifically, since Mike and I discussed security vulnerabilities last week. |
Also tagging @kevin-benton as his team has significantly more experience with security vulnerability scanning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving even though when you switch the container
values back to main my review will be dismissed
This resolves 960 security vulnerabilities. Mainly by switching compatible images to an
alpine
base image. Other improvements include updating base OS versions and updating packages. There are 25 remaining security vulnerabilities, all of which are Low/Medium by Snyk (level documentation). All of the remaining vulnerabilities are in theutil
image (which uses Ubuntu 24.04). We do anapt-get upgrade
in the image and I've skimmed most of the remaining vulnerabilities and they have no fixed version in 24.04. So the only "fix" would be to change to a different image that does not have those vulnerabilities.One important thing to note, the Python alpine-based images (
python:3.13.1-alpine
) are all using the 3.21 release from 12/05/2024. So it's unlikely that it has no vulnerabilities, but rather that those have not been discovered and reported. Here is the list from the prior 3.20 release. The R image (ghcr.io/r-hub/r-minimal/r-minimal:4.4.2
) uses the older 3.19 release with slightly more vulnerabilities.Before submitting this PR, please make sure:
scripts/
ordocker/
directories, please ensure any image versions have been incremented accordingly!