Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bacterial contamination documentation #88
base: master
Are you sure you want to change the base?
Bacterial contamination documentation #88
Changes from 5 commits
5d94f95
1cd9b35
de1fe79
04ed3a9
5e15b05
9817ae8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buccal -> buccal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the warning in the description field going to be relevant once we vend the
aln
files? I don't think so right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is up to the team. In my opinion, there is still some usefulness to the warning. There still exist bacterial reads in the files. We also have not quantitatively measured the mapping rate of bacterial reads in
aln
data. We have just observed that the mapping rates are lower and that we have not previously noticed the issue inaln
aligned data.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this plot is sufficient to draw the conclusion that mem aligns a higher proportion of reads of dubious origin. We don't know for sure that the dubious reads are the ones mem is aligning. I think we still have evidence of this (like manually inspecting the pillars of doom in the bams), but this makes it seem like you can conclude that from the plot. I would update the wording to make that clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mention here that we tried many alternative approaches to try to clean the bacterial reads from the data. Ultimately, we ended up choosing bwa aln because... etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that it is accurate to state that we tried alternative approaches. We considered and discarded a number of strategies. We did pilot work for one or two alternative strategies, which I allude to in the final sentence. Unless there is additional work of which I am unaware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the seed length discussion should probably go higher up. It seems too detailed for the conclusion, and it's new information, which doesn't fit well in the conclusion.
What does "with requiring additional post-processing" mean? I assume that should be "without" correct?